Add the Frdm stbc agm01 9-axis sensor shield #31812
Conversation
hollerdawg
requested review from
MaureenHelm,
erwango and
nashif
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
area: Documentation
area: Shields
hollerdawg
changed the title
hollerdawg
force-pushed
the
frdm_stbc_agm01
branch
2 times, most recently
from
8eb1aa1 to
58a62c6
Compare
There was a problem hiding this comment.
You can generalize this more and say it's compatible with any board that has an Arduino header
There was a problem hiding this comment.
Did you do this to make the fxos8700 sample use the shield instance? I think this might be better done as an application overlay
There was a problem hiding this comment.
Did you do this to make the fxos8700 sample use the shield instance?
Yes, I did.
an application overlay
This is exactly what I was missing, thanks!
There was a problem hiding this comment.
I couldn't figure out a way to apply the overlay only when both the frdm_stbc_agm01 and the frdm_k22f are selected. I removed this overlay though since the user could apply their own if they feel they need to.
hollerdawg
force-pushed
the
frdm_stbc_agm01
branch
from
58a62c6 to
0638648
Compare
There was a problem hiding this comment.
Please capitalize the first word
There was a problem hiding this comment.
The scan code check is failing because you need to add a copyright here
There was a problem hiding this comment.
Ah, thank you. Not sure why I missed that.
The frdm_stbc_agm01 implements an fxos8700 and fxas21002 to provide a 9-axis sensor solution. Signed-off-by: Ryan Holleran <[email protected]>
Provide the arduino_i2c node name from i2c_0. Provide pinmux for frdm_stbc_agm01. The frdm_stbc_agm01 supplies access to an FXOS8700 and FXAS21002. when using frdm_stbc_agm01 with frdm_k22f, the FXAS21002 sample sensor project can be utilized and the FXOS8700 sample sensor project utilizes the shield's FXOS8700. Signed-off-by: Ryan Holleran <[email protected]>
hollerdawg
force-pushed
the
frdm_stbc_agm01
branch
from
0638648 to
c35775b
Compare
| | PORT_PCR_ODE_MASK); | ||
| #endif | ||
|
|
||
| #if CONFIG_SHIELD_FRDM_STBC_AGM01 |
There was a problem hiding this comment.
Is this the correct way? I mean, adding a CONFIG option for a shield in the board part itself. I remember I had a similar request adding a shield for a microphone but I seem to remember I just added the pinmux part in the shield context itself. But I'm not able to recall it neither to find this out. @erwango, do you remember?
There was a problem hiding this comment.
Indeed, when possible this should be avoided but this depends if platform has a more generic way to enable pins.
On that part I rely on @MaureenHelm
There was a problem hiding this comment.
Indeed it isn't ideal, but we don't have more generic way to configure pins on this SoC family yet.
4 participants
No description provided.